Repository navigation
fix: link check should ignore certain issues - #980
Merged
Merged
Conversation
a-zw
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
October 16, 2026 15:09
Contributor
|
Documentation preview for this pull request is available at: |
There was a problem hiding this comment.
🟡 Changes recommended
The 504 allowlist entry can hide unavailable links, and the public documentation is incomplete.
1 open issue
What changed in this PR
This pull request updates link checking to ignore selected HTTP responses while preserving existing anchor-error handling.
Changes:
- Adds filtering for selected HTTP status codes.
- Records ignored links through the existing reporting path.
| File | Review notes |
|---|---|
src/extensions/broken_link_fix.py |
Remove or separately handle 504; update the setup() docstring to document ignored HTTP codes. |
Review effort: Lite
504 Gateway Timeout is a genuine server-side failure and hides truly dead pages.
dcalavrezo-qorix
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
We had a case of "403 Client Error: Forbidden" with the link-check.
This is not a good reason for a red check as the build probably just lacks credentials which a browser might have.
So, link-check should be ok with certain HTTP response codes.
🚨 Impact Analysis
✅ Checklist